Add tr gwas #26
Add tr gwas #26
Conversation
There was a problem hiding this comment.
Thanks for submitting this PR!
I made mostly minor comments. Once those are addressed we can merge.
See in particular the comment on automatic filtering of covariates - this can be addressed in the next PR but should be high on our list to avoid accidental filtering of covariates we didn't mean to in future runs.
| data.to_csv(covar_file_path, sep="\t", index=False) | ||
|
|
||
| print(f"Done converting {args.phenotype} to plink format") | ||
| return plink_pheno,data |
There was a problem hiding this comment.
don't need to return these since they are not used. can remove this line
There was a problem hiding this comment.
Hi, when I removed return line, it still output the two files we need but with this error, cuz return is None
plink_pheno,data = main()
TypeError: cannot unpack non-iterable NoneType object
|
Thank you for all the comments! I made the changes suggested in the comments. If everything looks good I will confirm merge. |
add tr-gwas script and wdl. It enables running tr gwas genome wide on AoU cloud environment