Add ability to gc builder cache #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #46 +/- ##
==========================================
- Coverage 78.07% 77.95% -0.13%
==========================================
Files 8 8
Lines 561 576 +15
==========================================
+ Hits 438 449 +11
- Misses 123 127 +4
Continue to review full report at Codecov.
|
|
.... why is the actions not triggering? |
|
Probably because there was a conflict that GitHub didn't tell me about because of the PR's draft status. |
|
bors: r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft while blocked on rust-lang/hashbrown#163
Also likely useful along these lines: a preload function that takes an
ArcBorrow<'_, Node>and preloads the cache with the node and any transitive children.drain_filteris annoying -- what's the polarity of the filter? -- so this definitely needs a test to make sure it's keeping the correct elements.