Added support for ARM #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # Tranga/Server.cs
Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 6.6.1 to 6.7.0. - [Release notes](https://github.com/docker/build-push-action/releases) - [Commits](docker/build-push-action@v6.6.1...v6.7.0) --- updated-dependencies: - dependency-name: docker/build-push-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
vonProteus
commented
Aug 31, 2024
vonProteus
commented
Aug 31, 2024
vonProteus
commented
Aug 31, 2024
vonProteus
commented
Aug 31, 2024
Dockerfile-base
Outdated
There was a problem hiding this comment.
moved to main Dockerfile
vonProteus
commented
Aug 31, 2024
Comment on lines
17
to
44
| BrowserFetcher browserFetcher = new BrowserFetcher(); | ||
| foreach(string rev in browserFetcher.LocalRevisions().Where(rev => rev != ChromiumVersion)) | ||
| browserFetcher.Remove(rev); | ||
| if (!browserFetcher.LocalRevisions().Contains(ChromiumVersion)) | ||
| { | ||
| Log("Downloading headless browser"); | ||
| DateTime last = DateTime.Now.Subtract(TimeSpan.FromSeconds(5)); | ||
| browserFetcher.DownloadProgressChanged += (_, args) => | ||
| { | ||
| double currentBytes = Convert.ToDouble(args.BytesReceived) / Convert.ToDouble(args.TotalBytesToReceive); | ||
| if (args.TotalBytesToReceive == args.BytesReceived) | ||
| Log("Browser downloaded."); | ||
| else if (DateTime.Now > last.AddSeconds(1)) | ||
| { | ||
| Log($"Browser download progress: {currentBytes:P2}"); | ||
| last = DateTime.Now; | ||
| } | ||
|
|
||
| }; | ||
| if (!browserFetcher.CanDownloadAsync(ChromiumVersion).Result) | ||
| { | ||
| Log($"Can't download browser version {ChromiumVersion}"); | ||
| throw new Exception(); | ||
| } | ||
| await browserFetcher.DownloadAsync(ChromiumVersion); | ||
| } | ||
|
|
There was a problem hiding this comment.
chrome is a part of base image now
because Puppeteer cant download arm version of chrome
There was a problem hiding this comment.
Could you rename method to "StartBrowser" for readabilitys sake?
vonProteus
commented
Aug 31, 2024
vonProteus
commented
Aug 31, 2024
vonProteus
commented
Aug 31, 2024
vonProteus
commented
Aug 31, 2024
…ocker/build-push-action-6.7.0 Bump docker/build-push-action from 6.6.1 to 6.7.0
Cuttingedge merge candidate
Closed
|
Gonna merge to cuttingedge first, see if changes work |
|
arm image is build only in master branch |
|
Yeah sorry, worded that wrong, gonna test locally with cuttingedge-branch, then merge into master |
|
anyway now enabling arm images in other branches is only changing |
Merged
C9Glax
added a commit
that referenced
this pull request
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ARM64 Support #6
related to C9Glax/tranga-website#116
https://hub.docker.com/layers/vonproteus/glax-tranga-api/latest/images/sha256-a1cb9859b33d83c271015c70be4a7f214914b5c770e276a6cb1b77ad7a3734fe?context=explore