[py-icon4py] Modifications for merge of greenline #834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
abishekg7
commented
Sep 15, 2023
|
This definitely feels like a new issue in v0.20.1. Didn't have this problem before the rebase.
|
|
launch jenkins py-isort py-poetry-core py-scikit-build-core py-tabulate py-ghex py-pytest-mpi serialbox |
balfrin🟢 unit test
🟢 integration test🟢 system test
|
tsa🟢 unit test
🟢 integration test🟢 system test
|
daint🟢 unit test
🟢 integration test🟢 system test
|
jonasjucker
reviewed
Sep 19, 2023
jonasjucker
reviewed
Sep 19, 2023
| from spack.pkg.builtin.py_poetry_core import PyPoetryCore as SpackPyPoetryCore | ||
|
|
||
|
|
||
| # TODO (magdalena) mostly copied from https://github.com/spack/spack/blob/develop/var/spack/repos/builtin/packages/py-poetry-core/package.py |
There was a problem hiding this comment.
Still needed?
Spack has now version 0.20.1
There was a problem hiding this comment.
Perhaps not needed, but Magdalena had added a recent version (1.6.1). Will test with inbuilt.
jonasjucker
reviewed
Sep 19, 2023
|
Just ran some checks on icon4py, and I removed the |
|
launch jenkins py-isort py-scikit-build-core py-tabulate py-ghex py-pytest-mpi serialbox |
balfrin🟢 unit test
🟢 integration test
|
daint🟢 unit test
🟢 integration test
|
|
system tests need ’Test’ in name. |
|
launch jenkins py-isort py-scikit-build-core py-tabulate py-ghex py-pytest-mpi serialbox |
balfrin🟢 unit test
🟢 integration test
|
daint🟢 unit test
🟢 integration test
|
tsa🟢 unit test
🟢 integration test
|
jonasjucker
approved these changes
Sep 19, 2023
|
launch jenkins py-gt4py py-icon4py |
|
launch jenkins py-icon4py |
tsa🟢 unit test
🟢 integration test
|
balfrin🟢 unit test
🟢 integration test
|
daint🟢 unit test
🟢 integration test
|
jonasjucker
changed the title
|
@abishekg7 You can merge! |
|
@jonasjucker thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just to not mess things up, using a new branch for the rebase of this #825