Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gt4py: Add 1.0.3.10 #1018

Merged
merged 9 commits into from
Nov 28, 2024
Merged

gt4py: Add 1.0.3.10 #1018

merged 9 commits into from
Nov 28, 2024

Conversation

halungge
Copy link
Contributor

Add new version to py-gt4py package for tag icon4py_20241113

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 17, 2024 •
edited
Loading

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-11-28 12:53 UTC

@halungge
Copy link
Contributor Author

launch jenkins spack

@dominichofer dominichofer changed the title add new gt4py version for tag icon4py_20241113 gt4py: Add 1.0.3.10 Nov 17, 2024
@dominichofer
Copy link
Contributor

launch jenkins

@halungge halungge marked this pull request as ready for review November 27, 2024 10:04
@halungge
Copy link
Contributor Author

launch jenkins

@halungge
Copy link
Contributor Author

launch jenkins

@halungge
Copy link
Contributor Author

launch jenkins

@halungge
Copy link
Contributor Author

launch jenkins

@halungge halungge requested a review from jonasjucker November 27, 2024 13:45
jonasjucker
jonasjucker reviewed Nov 27, 2024
View reviewed changes
test/system_test.py Outdated Show resolved Hide resolved
jonasjucker
jonasjucker requested changes Nov 27, 2024
View reviewed changes
Copy link
Contributor

@jonasjucker jonasjucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove main as tested version.

And reconsider which versions to keep in the recipe of icon4py and gt4py.
Each version potentially increases maintenance cost.

@halungge
Copy link
Contributor Author

launch jenkins

@jonasjucker
Copy link
Contributor

@halungge One test fails, see https://jenkins-mch.cscs.ch/job/Spack/job/spack_PR/1798/artifact/log/[email protected]_%[email protected]
Please fix it too :-)

@halungge
Copy link
Contributor Author

launch jenkins

@halungge halungge requested a review from jonasjucker November 28, 2024 10:57
@jonasjucker jonasjucker merged commit 5887a0b into main Nov 28, 2024
1 check passed
@jonasjucker jonasjucker deleted the gt4py_version_icon4py_20241113 branch November 28, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonasjucker jonasjucker jonasjucker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@halungge @dominichofer @jonasjucker