Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python: Remove workaround for Tsa #1004

Merged
merged 3 commits into from
Oct 2, 2024
Merged

python: Remove workaround for Tsa #1004

merged 3 commits into from
Oct 2, 2024

Conversation

dominichofer
Copy link
Contributor

@dominichofer dominichofer commented Sep 30, 2024 •
edited
Loading

The link to scales-ppm's repo is dead, therefore 2 tests failed and had to be removed.

@dominichofer
Copy link
Contributor Author

launch jenkins all

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 30, 2024 •
edited
Loading

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-10-02 09:33 UTC

@jenkins-apn
Copy link

balfrin

🟢 unit test
Test
🟢summary
🟢 integration test
Test
🟢clang-format-spack_info
🟢clang-format-spack_spec
🟢cosmo-eccodes-definitions-spack_info
🟢cosmo-eccodes-definitions-spack_spec
🟢cosmo-spack_info
🟢cosmo-spack_spec
🟢ecbuild-spack_info
🟢ecbuild-spack_spec
🟢eccodes-spack_info
🟢eccodes-spack_spec
🟢fdb-fortran-spack_info
🟢fdb-fortran-spack_spec
🟢fdb-spack_info
🟢fdb-spack_spec
🟢flexpart-cosmo-spack_info
🟢flexpart-cosmo-spack_spec
🟢flexpart-ifs-spack_info
🟢flexpart-ifs-spack_spec
🟢icon-ham-spack_info
🟢icon-ham-spack_spec
🟢icon-spack_info
🟢icon-spack_spec
🟢icon_extra-config-args=--disable-new_feature,--enable-old_config_arg-spack_spec
🟢dace_icon.-O1-spack_spec
🟢icon_serialization=create-spack_spec
🟢icontools-spack_info
🟢icontools-spack_spec
🟢int2lm-spack_info
🟢int2lm-spack_spec
🟢int2lm_+parallel-spack_spec
🟢int2lm_~parallel-spack_spec
🟢libcdi-pio-spack_info
🟢libcdi-pio-spack_spec
🟢libfyaml-spack_info
🟢libfyaml-spack_spec
🟢libgrib1-spack_info
🟢libgrib1-spack_spec
🟢libtorch-spack_info
🟢libtorch-spack_spec
🟢makedepf90-spack_info
🟢makedepf90-spack_spec
🟢metkit-spack_info
🟢metkit-spack_spec
🟢oasis-spack_info
🟢oasis-spack_spec
🟢py-cytoolz-spack_info
🟢py-cytoolz-spack_spec
🟢py-devtools-spack_info
🟢py-devtools-spack_spec
🟢py-factory-boy-spack_info
🟢py-factory-boy-spack_spec
🟢py-frozendict-spack_info
🟢py-frozendict-spack_spec
🟢py-gridtools-cpp-spack_info
🟢py-gridtools-cpp-spack_spec
🟢py-gt4py-spack_info
🟢py-gt4py-spack_spec
🟢py-hatchling-spack_info
🟢py-hatchling-spack_spec
🟢py-icon4py-spack_info
🟢py-icon4py-spack_spec
🟢py-inflection-spack_info
🟢py-inflection-spack_spec
🟢py-lark-spack_info
🟢py-lark-spack_spec
🟢py-pytest-factoryboy-spack_info
🟢py-pytest-factoryboy-spack_spec
🟢py-tabulate-spack_info
🟢py-tabulate-spack_spec
🟢py-typing-extensions-spack_info
🟢py-typing-extensions-spack_spec
🟢pytorch-fortran-proxy-spack_info
🟢pytorch-fortran-proxy-spack_spec
🟢pytorch-fortran-spack_info
🟢pytorch-fortran-spack_spec
🟢scales-ppm-spack_info
🟢scales-ppm-spack_spec
🟢xpmem-spack_info
🟢xpmem-spack_spec
🟢yaxt-spack_info
🟢yaxt-spack_spec
🔴 system test
Test
🟢[email protected]_nvhpc
🟢[email protected]_nvhpc_+coupling_serialization=create_+emvorado_+mpi_gpu=openacc+cuda_cuda_arch=80
🟢[email protected]
🟢install_cosmo_eccodes_definitions_version-cosmo-eccodes-definitions_@2.19.0.7
🟢install_cosmo_eccodes_definitions_version-cosmo-eccodes-definitions_@2.25.0.1
🔴install_default-scales-ppm
🟢[email protected]
🟢[email protected]_gcc
🟢[email protected]_nvhpc
🟢install_fdb_fortran-fdb-fortran
🟢[email protected]
🟢[email protected]
🟢install_flexpart_ifs_version-flexpart-ifs_@fdb
🟢[email protected]_gcc
🟢[email protected]
🟢install_int2lm_version_3_00_nvhpc_fixed_definitions-int2lm_@int2lm-3.00_nvhpc_^[email protected]
🔴install_libcdi_pio_default-libcdi-pio
🟢install_libfyaml_default-libfyaml
🟢install_libgrib1_22_01_2020_nvhpc-libgrib1_@22-01-2020nvhpc
🟢install_libtorch_default-libtorch
🟢[email protected]
🟢[email protected]_nvhpc
🟢[email protected]
🟢[email protected]
🟢[email protected]
🟢install_py_hatchling_default-py-hatchling
🟢install_py_icon4py_version_0_0_10-py-icon4py_@_0.0.10_gcc_^[email protected]
🟢install_py_icon4py_version_0_0_11-py-icon4py_@_0.0.11_gcc_^[email protected]
🟢install_py_icon4py_version_0_0_13-py-icon4py_@_0.0.13_gcc_^[email protected]
🟢install_py_inflection_default-py-inflection
🟢install_py_pyfactoryboy_default-py-pytest-factoryboy
🟢install_py_tabulate_default-py-tabulate
🟢install_py_typing_extensions_default-py-typing-extensions
🟢install_pytorch_fortran_proxy_version_0_4-pytorch-fortran-proxy@0.4gcc_^[email protected]
🟢[email protected]_^[email protected]_^[email protected]_^gmakegcc_^cmakegcc
🟢install_yaxt_default-yaxt
🟢py_cytoolz_install_default-py-cytoolz
🟢py_devtools_install_default-py-devtools
🟢py_factory_boy_install_default-py-factory-boy
🟢py_frozendict_install_default-py-frozendict
🟢py_gridtools_cpp_install_default-py-gridtools-cpp

@dominichofer
Copy link
Contributor Author

launch jenkins all

@jenkins-apn
Copy link

balfrin

🟢 unit test
Test
🟢summary
🟢 integration test
Test
🟢clang-format-spack_info
🟢clang-format-spack_spec
🟢cosmo-eccodes-definitions-spack_info
🟢cosmo-eccodes-definitions-spack_spec
🟢cosmo-spack_info
🟢cosmo-spack_spec
🟢ecbuild-spack_info
🟢ecbuild-spack_spec
🟢eccodes-spack_info
🟢eccodes-spack_spec
🟢fdb-fortran-spack_info
🟢fdb-fortran-spack_spec
🟢fdb-spack_info
🟢fdb-spack_spec
🟢flexpart-cosmo-spack_info
🟢flexpart-cosmo-spack_spec
🟢flexpart-ifs-spack_info
🟢flexpart-ifs-spack_spec
🟢icon-ham-spack_info
🟢icon-ham-spack_spec
🟢icon-spack_info
🟢icon-spack_spec
🟢icon_extra-config-args=--disable-new_feature,--enable-old_config_arg-spack_spec
🟢dace_icon.-O1-spack_spec
🟢icon_serialization=create-spack_spec
🟢icontools-spack_info
🟢icontools-spack_spec
🟢int2lm-spack_info
🟢int2lm-spack_spec
🟢int2lm_+parallel-spack_spec
🟢int2lm_~parallel-spack_spec
🟢libcdi-pio-spack_info
🟢libcdi-pio-spack_spec
🟢libfyaml-spack_info
🟢libfyaml-spack_spec
🟢libgrib1-spack_info
🟢libgrib1-spack_spec
🟢libtorch-spack_info
🟢libtorch-spack_spec
🟢makedepf90-spack_info
🟢makedepf90-spack_spec
🟢metkit-spack_info
🟢metkit-spack_spec
🟢oasis-spack_info
🟢oasis-spack_spec
🟢py-cytoolz-spack_info
🟢py-cytoolz-spack_spec
🟢py-devtools-spack_info
🟢py-devtools-spack_spec
🟢py-factory-boy-spack_info
🟢py-factory-boy-spack_spec
🟢py-frozendict-spack_info
🟢py-frozendict-spack_spec
🟢py-gridtools-cpp-spack_info
🟢py-gridtools-cpp-spack_spec
🟢py-gt4py-spack_info
🟢py-gt4py-spack_spec
🟢py-hatchling-spack_info
🟢py-hatchling-spack_spec
🟢py-icon4py-spack_info
🟢py-icon4py-spack_spec
🟢py-inflection-spack_info
🟢py-inflection-spack_spec
🟢py-lark-spack_info
🟢py-lark-spack_spec
🟢py-pytest-factoryboy-spack_info
🟢py-pytest-factoryboy-spack_spec
🟢py-tabulate-spack_info
🟢py-tabulate-spack_spec
🟢py-typing-extensions-spack_info
🟢py-typing-extensions-spack_spec
🟢pytorch-fortran-proxy-spack_info
🟢pytorch-fortran-proxy-spack_spec
🟢pytorch-fortran-spack_info
🟢pytorch-fortran-spack_spec
🟢scales-ppm-spack_info
🟢scales-ppm-spack_spec
🟢xpmem-spack_info
🟢xpmem-spack_spec
🟢yaxt-spack_info
🟢yaxt-spack_spec
🟢 system test
Test
🟢[email protected]_nvhpc
🟢[email protected]_nvhpc_+coupling_serialization=create_+emvorado_+mpi_gpu=openacc+cuda_cuda_arch=80
🟢[email protected]
🟢install_cosmo_eccodes_definitions_version-cosmo-eccodes-definitions_@2.19.0.7
🟢install_cosmo_eccodes_definitions_version-cosmo-eccodes-definitions_@2.25.0.1
🟢[email protected]
🟢[email protected]_gcc
🟢[email protected]_nvhpc
🟢install_fdb_fortran-fdb-fortran
🟢[email protected]
🟢[email protected]
🟢install_flexpart_ifs_version-flexpart-ifs_@fdb
🟢[email protected]_gcc
🟢[email protected]
🟢install_int2lm_version_3_00_nvhpc_fixed_definitions-int2lm_@int2lm-3.00_nvhpc_^[email protected]
🟢install_libfyaml_default-libfyaml
🟢install_libgrib1_22_01_2020_nvhpc-libgrib1_@22-01-2020nvhpc
🟢install_libtorch_default-libtorch
🟢[email protected]
🟢[email protected]_nvhpc
🟢[email protected]
🟢[email protected]
🟢[email protected]
🟢install_py_hatchling_default-py-hatchling
🟢install_py_icon4py_version_0_0_10-py-icon4py_@_0.0.10_gcc_^[email protected]
🟢install_py_icon4py_version_0_0_11-py-icon4py_@_0.0.11_gcc_^[email protected]
🟢install_py_icon4py_version_0_0_13-py-icon4py_@_0.0.13_gcc_^[email protected]
🟢install_py_inflection_default-py-inflection
🟢install_py_pyfactoryboy_default-py-pytest-factoryboy
🟢install_py_tabulate_default-py-tabulate
🟢install_py_typing_extensions_default-py-typing-extensions
🟢install_pytorch_fortran_proxy_version_0_4-pytorch-fortran-proxy@0.4gcc_^[email protected]
🟢[email protected]_^[email protected]_^[email protected]_^gmakegcc_^cmakegcc
🟢install_yaxt_default-yaxt
🟢py_cytoolz_install_default-py-cytoolz
🟢py_devtools_install_default-py-devtools
🟢py_factory_boy_install_default-py-factory-boy
🟢py_frozendict_install_default-py-frozendict
🟢py_gridtools_cpp_install_default-py-gridtools-cpp

@jonasjucker
Copy link
Contributor

The link to libcdi is still https://gitlab.dkrz.de/mpim-sw/libcdi, so it looks more like a permission error to me.

@jonasjucker
Copy link
Contributor

But since we anyway don't really use these packages one could also completely remove the tests, not just commenting.

@dominichofer dominichofer merged commit a97d919 into main Oct 2, 2024
2 of 3 checks passed
@dominichofer dominichofer deleted the python branch October 2, 2024 09:32
@dominichofer
Copy link
Contributor Author

The problem is scales-ppm. These links are dead:

    homepage = "https://www.dkrz.de/redmine/projects/scales-ppm"
    url = "https://www.dkrz.de/redmine/attachments/download/500/ppm-1.0.6.tar.gz"
    list_url = "https://www.dkrz.de/redmine/projects/scales-ppm/files"

@dominichofer
Copy link
Contributor Author

But since we anyway don't really use these packages one could also completely remove the tests, not just commenting.

Good point! I created an issue for it: #1006

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonasjucker jonasjucker jonasjucker approved these changes

@leclairm leclairm Awaiting requested review from leclairm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dominichofer @jenkins-apn @jonasjucker