Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed prognostic state list, and thus any state. Swapping of
now
andnew
variables is done externally in Fortran. This lead to all timesteps verifying against the Fortran reference except one fieldmass_flx_ic
, a major improvement over dycore verifying only in odd timesteps where no swapping was occurring. This suggests that the previous swapping/state in the granule introduces a bug somewhere.Also added
grid_init_dycore
, which enables running dycore granule in parallel. There are still some issues with GHEX however. On GPU GHEX grid decomposition works, but then there are compilation errors in the stencils. On CPU the current GHEX buildfails to allocate memory on the GPU
, which might be due to it having been built in GPU mode.