Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stateless dycore granule #628

Open
wants to merge 2 commits into
base: debug_dycore
Choose a base branch
from
Open

Conversation

samkellerhals
Copy link
Contributor

@samkellerhals samkellerhals commented Dec 19, 2024

Removed prognostic state list, and thus any state. Swapping of now and new variables is done externally in Fortran. This lead to all timesteps verifying against the Fortran reference except one field mass_flx_ic, a major improvement over dycore verifying only in odd timesteps where no swapping was occurring. This suggests that the previous swapping/state in the granule introduces a bug somewhere.

Also added grid_init_dycore, which enables running dycore granule in parallel. There are still some issues with GHEX however. On GPU GHEX grid decomposition works, but then there are compilation errors in the stencils. On CPU the current GHEX build fails to allocate memory on the GPU, which might be due to it having been built in GPU mode.

@samkellerhals samkellerhals changed the title Remove prognostic state list, make it stateless Stateless dycore granule Dec 20, 2024
Copy link

Mandatory Tests

Please make sure you run these tests via comment before you merge!

  • cscs-ci run default
  • launch jenkins spack

Optional Tests

To run benchmarks you can use:

  • cscs-ci run benchmark

To run tests and benchmarks with the DaCe backend you can use:

  • cscs-ci run dace

In case your change might affect downstream icon-exclaim, please consider running

  • launch jenkins icon

For more detailed information please look at CI in the EXCLAIM universe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant