Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs]: Fixes and deployment to gh-pages #618

Open
wants to merge 182 commits into
base: main
Choose a base branch
from

Conversation

samkellerhals
Copy link
Contributor

@samkellerhals samkellerhals commented Dec 3, 2024

Description

  • documentation has some additional features compared to the first PR (e.g. offset provider figures) as well as commenting functionality.
  • documentation is built on pushes to main and deployed to https://c2sm.github.io/icon4py

@jcanton jcanton mentioned this pull request Dec 9, 2024
dastrm and others added 10 commits December 9, 2024 11:16
Fixes two bugs in `compute_ppm4gpu_integer_flux` and
`compute_ppm4gpu_fractional_flux`, and refactors them for consistency
Set up a field source for interpolation fields.

(Restrictions) Adds a `FieldProvider` implementation for direct call of
`gtx.field_operator` (where possible), this one currently duplicates
some code with from the implementation for the `gtx.program.` It also
allows for computing on different backend than the target backend.

---------

Co-authored-by: Nicoletta Farabullini <[email protected]>
(FIX): fixes an test in `test_grid_manager.py` which was previousely
asserting nothing relevant.
- moved the following elements from
`model/common/src/icon4py/model/common/settings.py`to
`tools/src/icon4pytools/py2fgen/wrappers/settings.py`:
 ```
config = Icon4PyConfig()
backend = config.gt4py_runner
dace_orchestration = config.icon4py_dace_orchestration
xp = config.array_ns
device = config.device
limited_area = config.limited_area
```
- subsequent edit of imports and related in the code
- cleanup of left-over stencils backend specification on program definition
@samkellerhals
Copy link
Contributor Author

cscs-ci run default

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
model/atmosphere/dycore/docs/ext/icon4py_sphinx.py Outdated Show resolved Hide resolved
model/atmosphere/dycore/docs/ext/offset_providers.py Outdated Show resolved Hide resolved
model/atmosphere/dycore/docs/scidoc_processor.rst Outdated Show resolved Hide resolved
model/atmosphere/dycore/docs/scidoc_processor.rst Outdated Show resolved Hide resolved
model/atmosphere/dycore/docs/symbols_description.rst Outdated Show resolved Hide resolved
model/atmosphere/dycore/docs/symbols_description.rst Outdated Show resolved Hide resolved
model/atmosphere/dycore/docs/symbols_description.rst Outdated Show resolved Hide resolved
Copy link

Mandatory Tests

Please make sure you run these tests via comment before you merge!

  • cscs-ci run default
  • launch jenkins spack

Optional Tests

To run benchmarks you can use:

  • cscs-ci run benchmark

To run tests and benchmarks with the DaCe backend you can use:

  • cscs-ci run dace

In case your change might affect downstream icon-exclaim, please consider running

  • launch jenkins icon

For more detailed information please look at CI in the EXCLAIM universe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants