-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs]: Fixes and deployment to gh-pages #618
Open
samkellerhals
wants to merge
182
commits into
main
Choose a base branch
from
documentation_dycore02
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcanton
requested review from
egparedes,
nfarabullini,
halungge,
muellch and
OngChia
December 5, 2024 15:30
Open
Fixes two bugs in `compute_ppm4gpu_integer_flux` and `compute_ppm4gpu_fractional_flux`, and refactors them for consistency
Set up a field source for interpolation fields. (Restrictions) Adds a `FieldProvider` implementation for direct call of `gtx.field_operator` (where possible), this one currently duplicates some code with from the implementation for the `gtx.program.` It also allows for computing on different backend than the target backend. --------- Co-authored-by: Nicoletta Farabullini <[email protected]>
(FIX): fixes an test in `test_grid_manager.py` which was previousely asserting nothing relevant.
- moved the following elements from `model/common/src/icon4py/model/common/settings.py`to `tools/src/icon4pytools/py2fgen/wrappers/settings.py`: ``` config = Icon4PyConfig() backend = config.gt4py_runner dace_orchestration = config.icon4py_dace_orchestration xp = config.array_ns device = config.device limited_area = config.limited_area ``` - subsequent edit of imports and related in the code - cleanup of left-over stencils backend specification on program definition
cscs-ci run default |
Co-authored-by: Nicoletta Farabullini <[email protected]>
Mandatory Tests Please make sure you run these tests via comment before you merge!
Optional Tests To run benchmarks you can use:
To run tests and benchmarks with the DaCe backend you can use:
In case your change might affect downstream icon-exclaim, please consider running
For more detailed information please look at CI in the EXCLAIM universe. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
main
and deployed to https://c2sm.github.io/icon4py