Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

orchestrator fix: keep exchange object optional #570

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

DropD
Copy link
Contributor

@DropD DropD commented Oct 16, 2024

The orchestrator decorator looks for an optional exchange object on the self argument of the decorated function. One helper function has code that doesn't check whether it's present before optionally using it.

This small PR puts that code inside an if condition, the same check used throughout the module to check for presence of the exchange object.

@DropD DropD requested a review from kotsaloscv October 16, 2024 13:05
Copy link

Mandatory Tests

Please make sure you run these tests via comment before you merge!

  • cscs-ci run default
  • launch jenkins spack

Optional Tests

To run benchmarks you can use:

  • cscs-ci run benchmark

To run tests and benchmarks with the DaCe backend you can use:

  • cscs-ci run dace

In case your change might affect downstream icon-exclaim, please consider running

  • launch jenkins icon

For more detailed information please look at CI in the EXCLAIM universe.

for k, v in offset_providers.items()
if hasattr(v, "table")
}
if exchange_obj:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be better to set all these keys to the default value (0)?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would favour the if exchange_obj is not None and not isinstance(exchange_obj, decomposition.SingleNodeExchange) and set the pointers to 0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants