Add advection granule with horizontal transport #538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
halungge
requested changes
Sep 11, 2024
...ection/src/icon4py/model/atmosphere/advection/stencils/apply_horizontal_density_increment.py
Show resolved
Hide resolved
...n/src/icon4py/model/atmosphere/advection/stencils/apply_interpolated_tracer_time_tendency.py
Outdated
Show resolved
Hide resolved
...osphere/advection/src/icon4py/model/atmosphere/advection/stencils/compute_edge_tangential.py
Outdated
Show resolved
Hide resolved
...sphere/advection/stencils/compute_positive_definite_horizontal_multiplicative_flux_factor.py
Outdated
Show resolved
Hide resolved
...ion/src/icon4py/model/atmosphere/advection/stencils/compute_ppm4gpu_parabola_coefficients.py
Show resolved
Hide resolved
model/atmosphere/advection/tests/advection_tests/test_advection.py
Outdated
Show resolved
Hide resolved
model/atmosphere/advection/src/icon4py/model/atmosphere/advection/advection.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Magdalena <[email protected]>
Co-authored-by: Magdalena <[email protected]>
|
cscs-ci run default |
|
launch jenkins spack |
|
cscs-ci run default |
|
launch jenkins spack |
nfarabullini
requested changes
Oct 22, 2024
model/atmosphere/advection/src/icon4py/model/atmosphere/advection/advection.py
Show resolved
Hide resolved
...tion/src/icon4py/model/atmosphere/advection/stencils/average_horizontal_flux_subcycling_2.py
Outdated
Show resolved
Hide resolved
...tion/src/icon4py/model/atmosphere/advection/stencils/average_horizontal_flux_subcycling_3.py
Outdated
Show resolved
Hide resolved
...icon4py/model/atmosphere/advection/stencils/compute_antidiffusive_cell_fluxes_and_min_max.py
Outdated
Show resolved
Hide resolved
.../icon4py/model/atmosphere/advection/stencils/compute_ffsl_backtrajectory_length_indicator.py
Outdated
Show resolved
Hide resolved
...re/advection/stencils/compute_intermediate_horizontal_tracer_flux_from_cubic_coefficients.py
Outdated
Show resolved
Hide resolved
...here/advection/stencils/compute_intermediate_horizontal_tracer_flux_from_cubic_coeffs_alt.py
Outdated
Show resolved
Hide resolved
...ction/src/icon4py/model/atmosphere/advection/stencils/reconstruct_linear_coefficients_svd.py
Outdated
Show resolved
Hide resolved
...ection_stencil_tests/test_compute_positive_definite_horizontal_multiplicative_flux_factor.py
Show resolved
Hide resolved
|
cscs-ci run default |
|
launch jenkins spack |
|
cscs-ci run default |
|
launch jenkins spack |
|
cscs-ci run default |
|
launch jenkins spack |
model/atmosphere/advection/src/icon4py/model/atmosphere/advection/advection_vertical.py
Show resolved
Hide resolved
...re/advection/stencils/compute_intermediate_horizontal_tracer_flux_from_cubic_coefficients.py
Outdated
Show resolved
Hide resolved
...here/advection/stencils/compute_intermediate_horizontal_tracer_flux_from_cubic_coeffs_alt.py
Outdated
Show resolved
Hide resolved
...ction/src/icon4py/model/atmosphere/advection/stencils/reconstruct_linear_coefficients_svd.py
Outdated
Show resolved
Hide resolved
|
Mandatory Tests Please make sure you run these tests via comment before you merge!
Optional Tests To run benchmarks you can use:
To run tests and benchmarks with the DaCe backend you can use:
In case your change might affect downstream icon-exclaim, please consider running
For more detailed information please look at CI in the EXCLAIM universe. |
|
cscs-ci run default |
|
launch jenkins spack |
nfarabullini
approved these changes
Oct 29, 2024
halungge
approved these changes
Oct 31, 2024
OngChia
pushed a commit
that referenced
this pull request
Jan 14, 2025
* Add advection granule skeleton * Add first stencil call draft * Add second-order accurate horizontal transport * Make horizontal transport verify * Silence warnings and remove debug code * Adapt new code to main * Add proper advection test logging * Rename advection stencils * Modify highly generic advection stencils * Add missing python infrastructure files * Remove dead stencil call * Add advection test CI * Adjust for variable precision in stencils * Update AUTHORS.md * Modify dimension imports wherever possible * Add start/end indices to all advection stencils * Perform simplifications on advection stencils * Apply suggestions from code review Co-authored-by: Magdalena <[email protected]> * Apply suggestions from code review Co-authored-by: Magdalena <[email protected]> * Fix remaining issues * Duplicate and simplify two stencils * Add ntracer legend * Annotate advection stencils * Create horizontal and vertical advection classes * Fix all advection imports * Prepend underscore to private vars * Set grid type and backend for all stencils * Organize code into more independent classes * Fuse density increment stencils * Fix remaining issues * Shorten advection class names * Separate tracer and numerical flux * Fix remaining issues * Remove excessive casting in stencils * Fix most of the failing stencil tests * edits for offsets implementations * Make last stencil test pass * Fix remaining advection issues * Fix spack build * Introduce backend arguments in advection classes * Remove backend from program decorators --------- Co-authored-by: Magdalena <[email protected]> Co-authored-by: Nicoletta Farabullini <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.