Cleanup nh constants #339
Merged
Cleanup nh constants #339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… (generates warnings in pre-commit runs, section not present in other packages)
|
cscs-ci run |
|
launch jenkins spack |
|
Everything looks good. I think that initialization of solve_nonhydro is now finally clean. |
OngChia
approved these changes
Dec 14, 2023
| ) | ||
| @pytest.mark.datatest | ||
| def test_non_hydrostatic_params(savepoint_nonhydro_init): | ||
| config = config = NonHydrostaticConfig() |
There was a problem hiding this comment.
Probably config = is duplicated?
|
Mandatory Tests Please make sure you run these tests via comment before you merge!
Optional Tests In case your change might affect downstream icon-exclaim, please consider running
For more detailed information please look at CI in the EXCLAIM universe. |
|
cscs-ci run |
|
launch jenkins spack |
OngChia
pushed a commit
that referenced
this pull request
Jan 14, 2025
Calculate NhConstants inside NonHydrostaticParams and removes NhConstants from argument to the timestep.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calculates the values in
NhConstantsinsideNonHydrostaticParamsand removesNhConstantsfrom argument to the timestep.