-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add serialised data to ci #338
Changes from 1 commit
146f4d1
efdcb6c
a449d62
95d4533
32d8eca
2af5052
7872ae3
390721c
f1fb468
38adcce
3520d13
ac95551
1584e2c
f576f48
43fa823
3b9904f
a22537d
3f68853
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,7 +4,7 @@ _local | |
_external_src | ||
_reports | ||
tmp | ||
serialized_data | ||
testdata | ||
simple_mesh*.nc | ||
|
||
### GT4Py #### | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -43,7 +43,7 @@ variables: | |
NUM_PROCESSES: auto | ||
VIRTUALENV_SYSTEM_SITE_PACKAGES: 1 | ||
CSCS_NEEDED_DATA: icon4py | ||
SERIALIZED_DATA_PATH: "/apps/daint/UES/jenkssl/ciext/icon4py" | ||
TEST_DATA_PATH: "/apps/daint/UES/jenkssl/ciext/icon4py" | ||
|
||
build_job: | ||
extends: .build_template | ||
|
@@ -52,14 +52,14 @@ test_model_job_roundtrip_simple_grid: | |
extends: .test_template | ||
stage: test | ||
script: | ||
- tox -r -c model/ --verbose -- --benchmark-skip -n auto | ||
- tox -r -e run_stencil_tests -c model/ --verbose | ||
|
||
test_model_job_dace_cpu_simple_grid: | ||
extends: .test_template | ||
stage: test | ||
script: | ||
- pip install dace==$DACE_VERSION | ||
- tox -r -e run_stencil_tests -c model/ --verbose -- --benchmark-skip -n auto --backend=dace_cpu | ||
- tox -r -e run_stencil_tests -c model/ --verbose -- --backend=dace_cpu | ||
only: | ||
- main | ||
allow_failure: true | ||
|
@@ -69,7 +69,7 @@ test_model_job_dace_gpu_simple_grid: | |
stage: test | ||
script: | ||
- pip install dace==$DACE_VERSION | ||
- tox -r -e run_stencil_tests -c model/ --verbose -- --benchmark-skip -n auto --backend=dace_gpu | ||
- tox -r -e run_stencil_tests -c model/ --verbose -- --backend=dace_gpu | ||
only: | ||
- main | ||
allow_failure: true | ||
|
@@ -78,13 +78,13 @@ test_model_job_gtfn_cpu_simple_grid: | |
extends: .test_template | ||
stage: test | ||
script: | ||
- tox -r -e run_stencil_tests -c model/ --verbose -- --benchmark-skip -n auto --backend=gtfn_cpu | ||
- tox -r -e run_stencil_tests -c model/ --verbose -- --backend=gtfn_cpu | ||
|
||
test_model_job_gtfn_gpu_simple_grid: | ||
extends: .test_template | ||
stage: test | ||
script: | ||
- tox -r -e run_stencil_tests -c model/ --verbose -- --benchmark-skip -n auto --backend=gtfn_gpu | ||
- tox -r -e run_stencil_tests -c model/ --verbose -- --backend=gtfn_gpu | ||
|
||
test_tools_job: | ||
extends: .test_template | ||
|
@@ -97,7 +97,7 @@ benchmark_model_dace_cpu_icon_grid: | |
stage: benchmark | ||
script: | ||
- pip install dace==$DACE_VERSION | ||
- tox -r -e run_benchmarks -c model/ -- --benchmark-only --backend=dace_cpu --grid=icon_grid | ||
- tox -r -e run_benchmarks -c model/ -- --backend=dace_cpu --grid=icon_grid | ||
only: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I was wondering: does our (don't know how it works and currentlyit runs always all of the jobs and the benchmarks take quite long... once we add the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I am not sure to be honest since @edopao added these dace jobs, maybe he can explain more. I would assume these benchmarks run only on There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. As commented in today's standup meeting, the intention of this setting was to run the dace benchmark on main after PR is merged. However, this setting is ignored in our setup, as also noted above. I agree that we could have a separate CI pipeline for benchmarking, automatically triggered after PR is merged or by a daily job. |
||
- main | ||
when: manual | ||
|
@@ -107,7 +107,7 @@ benchmark_model_dace_gpu_icon_grid: | |
stage: benchmark | ||
script: | ||
- pip install dace==$DACE_VERSION | ||
- tox -r -e run_benchmarks -c model/ -- --benchmark-only --backend=dace_gpu --grid=icon_grid | ||
- tox -r -e run_benchmarks -c model/ -- --backend=dace_gpu --grid=icon_grid | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. do you need this double double-dashes? Or did you simply forget to delete? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes the double dashes are used to denote the end of arguments passed to tox itself, and that any subsequent arguments are to be treated as positional arguments passed to whatever command tox invokes, in this case |
||
only: | ||
- main | ||
when: manual | ||
|
@@ -116,10 +116,10 @@ benchmark_model_gtfn_cpu_icon_grid: | |
extends: .test_template | ||
stage: benchmark | ||
script: | ||
- tox -r -e run_benchmarks -c model/ -- --benchmark-only --backend=gtfn_cpu --grid=icon_grid | ||
- tox -r -e run_benchmarks -c model/ -- --backend=gtfn_cpu --grid=icon_grid | ||
|
||
benchmark_model_gtfn_gpu_icon_grid: | ||
extends: .test_template | ||
stage: benchmark | ||
script: | ||
- tox -r -e run_benchmarks -c model/ -- --benchmark-only --backend=gtfn_gpu --grid=icon_grid | ||
- tox -r -e run_benchmarks -c model/ -- --backend=gtfn_gpu --grid=icon_grid |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just leaving my 2 cents here: All of these jobs could be easily expressed using https://docs.gitlab.com/ee/ci/yaml/#needsparallelmatrix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will try this in a new PR.