Halo exchanges nh solve #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
solve_nonydro.py::timestep
…nnecessary domain bounds on stencil_66
add pytest cleanup that properly finalizes MPI
|
cscs-ci run |
|
launch jenkins spack |
|
cscs-ci run |
|
launch jenkins spack |
nfarabullini
reviewed
Nov 1, 2023
model/atmosphere/dycore/src/icon4py/model/atmosphere/dycore/nh_solve/solve_nonhydro.py
Show resolved
Hide resolved
|
cscs-ci run |
|
launch jenkins spack |
nfarabullini
approved these changes
Nov 3, 2023
|
cscs-ci run |
|
launch jenkins spack |
|
cscs-ci run |
|
launch jenkins spack |
|
cscs-ci run |
|
launch jenkins spack |
|
Mandatory Tests Please make sure you run these tests via comment before you merge!
Optional Tests In case your change might affect downstream icon-exclaim, please consider running
For more detailed information please look at CI in the EXCLAIM universe. |
|
cscs-ci run |
|
launch jenkins spack |
OngChia
pushed a commit
that referenced
this pull request
Jan 14, 2025
Adds halo exchanges to solve_nonhydro making it runnable on several nodes. * add convenience method exchange_and_wait in protocol of the `ExchangeRuntime` * remove unnecessary domain bounds on `mo_solve_nonhydro_stencil_66` includes some cleanups for `test_solve_nonhydro.py` * remove SimpleMesh from test_solve_nonhydro.py * predictor test: extract domain boundaries for Cells, remove total sizes magic numbers * predictor test: extract domain boundaries for Edges remove total sizes magic numbers * split `istep` , `jstep` fixtures into separate ones for `init` and `exit` rename `solve_nonhydro.py`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add halo exchanges to solve non hydro.
in single node SolveNonHydro test: