Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small improvements to config_paths fixture #86

Merged
merged 2 commits into from
Jan 16, 2025
Merged

Conversation

agoscinski
Copy link
Collaborator

Please read the commit descriptions for a description of this PR. I made them quite verbose.

Because the name of the config file is determined by the name of the
folder it is in we rename all test config files to `config.yml` so the
handling is easier.
To reuse the fixture logic in cases where not all use cases are needed
we move the logic to the function `generate_config_paths` that can be
reused in other fixtures.
@agoscinski agoscinski force-pushed the small-test-improvements branch from 5a940bc to d59e244 Compare January 12, 2025 18:40
Copy link
Contributor

@leclairm leclairm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, I wanted to do it already!
Maybe we can use more insightful names like config.txt => pretty_print.txt and config.svg => graph.svg
Feel free to take it into account or not.

@agoscinski agoscinski merged commit caced37 into main Jan 16, 2025
3 checks passed
@agoscinski agoscinski deleted the small-test-improvements branch January 16, 2025 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants