-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Icon namelist non optional #109
base: main
Are you sure you want to change the base?
Conversation
also add the last 2 missing `kw_only=True` to @DataClass
a684e91
to
e4045ef
Compare
strangely not caught by ruff
also make validator idempotent even if unused yet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am fine with using the kw_only
, it only restrains us from using the constructor with positional arguments which I don't think is important. Can we add a test that tests that it is optional? The test I see still adds a namelist.
EDIT: Wait as far as I experience, the namelist was not optional before. I thought this PR would make it optional, but the title says it is made non optional. If one does not have to modify anything in the namelist, then one does not need to specify the namelist in the config yaml as the names are hardcoded and they are assumed to be in the rootdir
.
We actually need the |
As advised by @DropD , we remove the necessity of ICON namelists being apparently optional for ICON tasks by using
@dataclass(kw_only=True)
. This is now used all over the code base.Some doctests are also added to
ConfigNamelist
andConfigIconTask