Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, all AppImages rely on the host to provide GTK icons. If an AppImage is used on a host without the required icons, they are not shown. This can by reproduced by running an AppImage without environment variables, e.g.
This PR adds the missing icons.
Implementation details
The icons are provided by first adding an icon theme that contains all used icons and then removing all unused icons to minimize the AppImage size. A lot of icon themes (incl. the default themes Adwaita for Debian and Yaru for Ubuntu) do not include the steam icon. The current choice is Paper which is available for all supported AppImages (Focal requires a PPA). A different theme may be chosen in future by simply changing the dependency. There are some sanity checks which break the build when a used icon is missing.
Some X11 dependencies (
libx11
,libxcb
,libxext
,libxfixes
) that have been added in AppImage: increase compatibility & add tests #17 were removed because they may cause a segmentation fault dependeing on the host environment (at least on a Ubuntu Noble host). I think it is correct to remove them because the X server is already running on the host, and thus all X11 related libraries should be taken from the host. In addition to the ci test, all AppImages have been started on Ubuntu Jammy and Ubuntu Noble. The Noble and Trixie AppImage still segfault as reported in the earlier PR, but this should be a different topic.A github CI build and release are available.