logger-hotfix #92
Merged
logger-hotfix #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this a fix for issue #85? If it's the case we will need someone to test it with a Linux distro. |
|
Yeah, I didn't see that issue. this is a fix for issue #85. |
Byte-Nova
approved these changes
May 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
context
In order to keep the commands on a separate line from the logs (so they aren't writing on top of each other), it has to erase an entire line which is done by replacing the entire line with spaces. In some cases the console will send the cursor to a new line when the current line is filled up (in this case filled with spaces). This ends up moving the current command down a line every time the user types something.
solution
This fix sets the space count to the entire width minus 1 to stop the console from moving to the next line when a line is filled up.