Exposed contexts as interfaces. Exposed original IncrementalGenerator… #30
Conversation
…InitializationContext and ILogger via prop-get with intellisense warnings.
| /// </summary> | ||
| /// <remarks>Provided as a convenience accessor to support advanced scenarios. Generally should not be directly | ||
| /// interacted with as it may produce side effects in the sgf generators. Use at your own risk.</remarks> | ||
| IncrementalGeneratorInitializationContext Context { get; } |
There was a problem hiding this comment.
I think it would be better to hide this from the interface and instead add it to the implementation then update the generators to take in ISgfInitializationContext instead.
This
public abstract void OnInitialize(SgfInitializationContext context);would become
public abstract void OnInitialize(ISgfInitializationContext context);The reason being is that people don't often read the documentation and learn from intelisense. If we expose the property they might use it and when they do they loose all the exception handling that SGF provides. There are for sure going to be use cases where you need it but for folks who really need it can read the docs or find out how to get it will a little digging.
|
I ended up making the changes here #38. The only real difference is I hid the base context. You have to do an explicit cast to the interface to get access to it. |
Exposed contexts as interfaces. Exposed original IncrementalGeneratorInitializationContext and ILogger via prop-get with intellisense warnings. closes #29