Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature to turn off emitting ModuleInitializerAttribute when bringing your own polyfills #26

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

scooter12
Copy link
Contributor

Added ability to recognize CompilerVisibleProperty set properties for controlling source generator options.
Added new build project property SgfAddModuleInitializerAttribute which when included in a source gen project's build pipeline and set to false (most commonly set in the project's .csproj file) will prevent the SgfAddModuleInitializerAttribute polyfill from being emitted. Use case is when utilizing other polyfill libraries.

… controlling source generator options.

Added new build project property SgfAddModuleInitializerAttribute which when included in a source gen project's build pipeline and set to false (most commonly set in the project's .csproj file) will prevent the SgfAddModuleInitializerAttribute polyfill from being emitted. Use case is when utilizing other polyfill libraries.
@ByronMayne
Copy link
Owner

I am happy someone came in and fixed up all my typos, It's like I am at work haha. I will take a look at this tonight. Thanks for putting the effort into adding these features.

The other options instead of using an attribute was rapping the polyfils with per-processor definitions which you can just turn off.

#if SGF_DISALBE_POLYFILS
  // blah 
#endif 

The advantage being you have to do less inspections

@scooter12
Copy link
Contributor Author

scooter12 commented Nov 27, 2024 via email

@ByronMayne
Copy link
Owner

Would it be possible to break the MR into two different ones?

  1. Added support for not adding ModuleInitializerAttribute polyfill
  2. Fixed Grammatical Errors and Typos

Just so the release notes will be more clear. Besides for that I have no problems merging it in

@scooter12
Copy link
Contributor Author

Yep. Done.

@ByronMayne
Copy link
Owner

Amazing thank you!

@ByronMayne ByronMayne merged commit f978790 into ByronMayne:master Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants