Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V2 dev #11

Merged
merged 74 commits into from
Apr 20, 2021
Merged

V2 dev #11

merged 74 commits into from
Apr 20, 2021

Conversation

NilsIrl
Copy link
Contributor

@NilsIrl NilsIrl commented Apr 15, 2020

Merge v2-dev into master

ArturKovacs and others added 30 commits October 31, 2019 02:09
@ArturKovacs
Run rust fmt. Implement list for Windows.
3f29636
@ArturKovacs
Implement purge_all and restore_all for Windows.
e06c825
@ArturKovacs
Fix purge_all and restore_all reading invvalid memory and not exe…
22d5181 
…cuting the operation on the requested items. Add test cases for `purge_all` and `restore_all`. Test are now thread safe.
@ArturKovacs
Now purge_all doesn't show a dialog on windows.
07e3bc2
@ArturKovacs
Changed std::mem::uninit and std::mem::zeroed to `std::mem::Maybe…
632a6fb 
…Uninit`. Plus ran Rustfmt.
@ArturKovacs
Improve the Error type and add create_remove_empty_folder test.
a940b66
@ArturKovacs
Add list implementation for linux.
5c73fea
@ArturKovacs
Now using the url crate for parsing the original location on Linux.
02ffe0b
@ArturKovacs
Added implementation of purge_all for Linux.
a90f9bf 
Also ran rustfmt and created a rustfmt config.
@ArturKovacs
Add Cirrus CI test.
e5c22c4
@ArturKovacs
Add Azure Pipelines CI.
760dfa6
@ArturKovacs
Update Azure's target operating systems.
cfb25b6
@ArturKovacs
Fix OS setup in Azure's config.
08db817
@ArturKovacs
Add MacOS and Linux as targets for CI tests.
e409a98
@ayazhafiz
refactor(mac): port mac implementation to work with v2
576fad7 
Updates the existing Mac implementation to compile with v2 of the
library. Does not add any new functionality other defining required
methods.

Tests fail for methods relating to `list`, `purge_all`, or
`restore_all`, which are unimplemented.
@ArturKovacs
Remove the Cirrus CI config.
fd597fc
@ArturKovacs
Merge pull request #6 from ayazhafiz/refactor/mac2
adf0ea4 
refactor(mac): port mac implementation to work with v2 (tests fail)
@ArturKovacs
Fix for list failing on Linux.
d6cb6ba 
This happened because `list` on Linux didn't handle paralell threads manipulating the trash correctly.
@ArturKovacs
Steps towards implementing remove_all.
20ba354
@ArturKovacs
Added a partialy implementaiton of remove_all.
1e03167 
Can't remove from non-root devices or partitions.
@ArturKovacs
Add ability to trash items from an external drive.
16f0ee1
@ArturKovacs
Merge branch 'v2-dev' into v2-linux
ecf521f
@ArturKovacs
Added RUST_BACKTRACE=1 to test.
c1cb106
@ArturKovacs
Merge branch 'v2-dev' into v2-linux
303a274
@ArturKovacs
Attempt to add RUST_BACKTRACE=1 again.
7bd6023
@ArturKovacs
Create home trash if doesn't yet exist.
e1b2aae 
Also added debug print line numbers.
@ArturKovacs
Fix creating the home trash folder.
10364c6
@ArturKovacs
Remove debug lines.
3ab9217
@ArturKovacs
Merge pull request #7 from ArturKovacs/v2-linux
b957f38 
Add version 2 implementation for linux.
@ArturKovacs
Improve collision handling and add collision test.
6db249b
@ArturKovacs
Ran cargo fmt
cf13e78
@ArturKovacs
Remove the WinNull workaround
d8ab41f
@ArturKovacs
Implement purge_all on Windows
9fc224d
@ArturKovacs
Implement restore_all for windows
baa5171
@ArturKovacs
Removed the silly PlatformApi error
61fa667
@ArturKovacs
Update the macos backend
e739014
@ArturKovacs
Update the macOS backend
eff82e4
@ArturKovacs
Rename extra to os_limited and other tweaks
29b6b11
@ArturKovacs
Documentation improvements
18337bf
@ArturKovacs
Tweaked tests and documentation
330b1ec
@ArturKovacs
Fix warnings on macOS
f12cea9
@ArturKovacs
Update the list example
a18d055
@ArturKovacs
Fix freedesktop errors
afd17c3
@ArturKovacs
Fix clippy error
a182fbc
@ArturKovacs
Don't run the CI for the nightly Rust
afa33ba
@ArturKovacs
Remove the Filesystem error kind
1138d8c
@ArturKovacs
Add more logging to the freedesktop implementation
a94b4ce
@ArturKovacs
Update readme, add changelog
4c1ece3
@ArturKovacs
Minor tweaks
1c43fe7
@ArturKovacs
More tweaks
ee2527a
@ArturKovacs
Fix clippy error
2158550
@ArturKovacs
Run cargo fmt
3ce2160
@ArturKovacs
Add test for NsFileManager delete method
8aea6ef
@ArturKovacs
Update the version number
28307a6
@ArturKovacs
Merge branch 'v2-dev' of https://github.com/ArturKovacs/trash-rs into…
e9047a3 
… v2-dev
@ArturKovacs
Copy link
Collaborator

My PR still hasn't been merged into winapi-rs but it doesn't matter because there's windows-rs which provides all the functionality needed, so from now on, the Windows implementation uses windows-rs.

I renamed the linux_windows module to os_limited partly because the linux implementation is actually a "FreeDesktop" implementation, and partly because os_limited looks neater than linux_windows in my opinion.

@ArturKovacs ArturKovacs merged commit 3dcac24 into master Apr 20, 2021
@ArturKovacs ArturKovacs deleted the v2-dev branch April 20, 2021 19:21
@ArturKovacs ArturKovacs mentioned this pull request Apr 21, 2021
Closed
@ArturKovacs ArturKovacs mentioned this pull request May 6, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NilsIrl @ArturKovacs @ayazhafiz