shortcut links implementation #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aogier
force-pushed
the
feature/32-shortcut-links
branch
from
c7bc27c to
25cc3d1
Compare
|
And it's available on crates.io |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! This PR implement an unopinionated management for
Linktype::Shortcuts type links as identified by pulldown-cmark. Resulting output preserve the author's choice of putting a link in a file footer rather than inlining it.I'm not totally convinced about
clone()ing/reallocating stuff in required support data structures but being a rust newbie I'm currently unable to provide a better solution, given that there is any.Hope this helps, thank you
see #32