Overhaul keyboard input handling #37
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The primary change here is that we do not use the unicode package to operate on strings. Instead, we implement XCB's xcb_convert_case function, which is a truer implementation of the specification, handling only those keysyms it should. In itself, this isn't a very useful change. It does, however, allow us to return keysyms, instead of strings, from interpretSymList. This is necessary to add support for handling numlock, which has to check whether the keysym is in specific ranges.
KeysymName returns the raw, unchanged name of a keysym. For example, the Compose file format has entries such as the following, which requires knowing the actual keysym names: <Multi_key> <space> <parenleft> : "˘" breve # BREVE
External code that operates directly on keysyms, for example to handle arrow or media keys, will want to compare keysyms to predeclared names.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overhaul keyboard input handling to make it more suitable for full fledged text input, not just keybindings. In particular, we add support for more modifiers (Mode_switch, AltGr, numlock), add more functions to get direct access to keysyms and their names, and improve keysym stringification to handle Unicode.