[enhancement] support ISO8601 offsets

[kevinburke]

For example, if I type date --iso-8601=seconds using the GNU date program, I get the output

2014-08-13T16:46:08-0700

It would be nice if this was parsed properly into a Time object, instead the code generates:

Near line 4, key 'date': Near line 4: Expected 'Z' in ISO8601 datetime, but found '-' instead.

Here's the relevant piece of code:

func lexDateAfterYear(lx *lexer) stateFn {
    formats := []rune{
        // digits are '0'.
        // everything else is direct equality.
        '0', '0', '-', '0', '0',
        'T',
        '0', '0', ':', '0', '0', ':', '0', '0',
        'Z',
    }
    for _, f := range formats {
        r := lx.next()
        if f == '0' {
            if !isDigit(r) {
                return lx.errorf("Expected digit in ISO8601 datetime, "+
                    "but found %q instead.", r)
            }
        } else if f != r {
            return lx.errorf("Expected %q in ISO8601 datetime, "+
                "but found %q instead.", f, r)
        }
    }
    lx.emit(itemDatetime)
    return lx.pop()
}

[BurntSushi]

Since this project maintains parity with the TOML spec, it isn't really appropriate to post specification changes here. In fact, this feature should hopefully get merged soon.

So I'll leave this issue open for now. It will likely be implemented eventually.

[kevinburke]

ah, whoops, didn't realize this was defined in the upstream spec.

Kevin Burke
phone: 925.271.7005 | kev.inburke.com

On Wed, Aug 13, 2014 at 5:26 PM, Andrew Gallant [email protected]
wrote:

Since this project maintains parity with the TOML spec, it isn't really
appropriate to post specification changes here. In fact, this feature
toml-lang/toml#189 should hopefully get merged
soon.

So I'll leave this issue open for now. It will likely be implemented
eventually.

—
Reply to this email directly or view it on GitHub
#58 (comment).

[cespare]

Closing this issue in favor of #96.