Provide a mechanism to compose type definitions #303
Conversation
This extends the syntax of the --type-add flag to allow including the globs of other already defined types. Fixes #83.
| for type_name in types { | ||
| let globs = self.types.get(type_name).unwrap().globs.clone(); | ||
| for glob in globs { | ||
| self.add(name, &glob)?; |
There was a problem hiding this comment.
Sorry, but this is going to fail CI because ripgrep's minimum version is currently Rust 1.12. You'll need to use try! here.
| using the --type-add flag again:\n\n\ | ||
| --type-add 'src:include:cpp,py,md' --type-add 'src:*.foo'\n\n\ | ||
| Note that type names must consist only of Unicode letters or \ | ||
| numbers. Punctuation characters are not allowed."); |
There was a problem hiding this comment.
These docs are great. Can you also add them to the man page in doc/rg.1.md? (You'll need to cd doc && ./convert-to-man to actually produce the man file, which can be viewed with man -l rg.1. If you can't get pandoc installed easily, that's OK, I can do the final conversion step.)
|
Oh, could you also add an integration test in |
|
I was able to install pandoc but I could not view the man file. Probably some OSX incompatibility? Either way, you might want to take a look yourself. |
|
Merged in ed01e80 |
|
Thanks! The doc formatting was a little off. I fixed that and also squashed the commits. Nice work! |
This extends the syntax of the --type-add flag to allow including the globs of
other already defined types.
Fixes #83.
Hi @BurntSushi, this is pretty much a straight implementation of your spec from #83, except that we are also allowing Unicode numbers in type names in addition to Unicode letters. Letters were not enough for the default types (curse you, m4).
I am no rust expert so I'd appreciate specific feedback on my add_def changes (or anything, for that matter). And let me know if I missed any places to put tests or documentation (or if I put the documentation in too many places; it did feel a bit repetitive).
Thanks!