Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bring the changelog up to date #180

Closed
wants to merge 4 commits into from

Conversation

striezel
Copy link

@striezel striezel commented Jul 4, 2021

Closes #176.

I hope I did not miss to document any important change here.

@striezel
Copy link
Author

@BurntSushi
Feel free to squash this into one commit in the case that it gets merged. I just thought it might be easier to review when there is one commit for each version bump.

@striezel
Copy link
Author

@BurntSushi: Just a friendly reminder that is has been over a year since the PR was created.

If there is anything wrong with the changes in this PR and this is causing the lack of feedback here, then please let me know so I can fix it.

@BurntSushi BurntSushi closed this in 62b0e31 Oct 6, 2023
@striezel
Copy link
Author

striezel commented Oct 9, 2023

Hmm. It probably wouldn't have hurt to add those changes before adding the warning in commit 62b0e31. 😞 The entries for some of the newer releases are already here, so it wouldn't have been much work to just merge them.

@striezel striezel deleted the changelog++ branch October 9, 2023 22:32
@BurntSushi
Copy link
Owner

It's easy to look at any one particular PR and say, "just merge it." But I would have had to review it, ask for changes (or do them myself) and check that everything is correct. What may seem to you like a matter of just clicking a button is to me at best 10 minutes of review and at worst tens of minutes. Now when you take that and put it into the context of how much free time I have and how these sorts of things compound over the dozens of projects I maintain, the time really starts to add up.

As a maintainer, I look for shortcuts where reasonable to reduce the burden. Changelogs for small low-activity projects like these are easy to drop. And if I'm dropping it, then dropping the (at least) ten minutes to review a PR for it is another shortcut.

Sorry this didn't get merged.

Repository owner locked as resolved and limited conversation to collaborators Oct 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changelog is not up to date
2 participants