implemented a workaround for Conul service discovary support. #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… solution in this PR works (please take it as just guidance on how to fix it) , i didnt had time to get fully familiar with your code base and just aplied a hot fix
|
Thanks for opening this pull request! If you have implemented new functions, write about them in the readme file. |
|
Hi @raga70, thanks for your PR. I can merge this PR if you:
thanks. |
Burgyn
requested changes
Mar 14, 2024
| @@ -46,6 +46,12 @@ public class DownstreamSwaggerDocsRepository : IDownstreamSwaggerDocsRepository | |||
| var clientName = _options.Value.HttpClientName ?? ((route?.DangerousAcceptAnyServerCertificateValidator ?? false) ? ServiceCollectionExtensions.IgnoreSslCertificate : string.Empty); | |||
| var httpClient = _httpClientFactory.CreateClient(clientName); | |||
|
|
|||
| if (!(url.StartsWith("http://") || url.StartsWith("https://"))) //the url that gets constructed when using consul misses the http schema , and trows an exception | |||
There was a problem hiding this comment.
Use StringComparison.InvariantCultureIgnoreCase. and remove comments
|
Hi @Burgyn I committed the changes you requested . |
Burgyn
approved these changes
Mar 18, 2024
|
Hi @raga70, unfortunately your changes failed tests. Please fix tests. |
…l when unit testing
|
I added nullability to my ServiceProviderType since the ServiceProviderConfiguration is in fact null when unit testing |
Burgyn
approved these changes
Mar 27, 2024
|
Thanks. This will be release soon as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implemented a workaround for Conul service discovery. Although the solution in this PR works (please take it as just guidance on how to fix it) , I did have time to get fully familiar with your code base and just aplied a hot fix.
PS: my ide made a bit of a reformatting on the files I touched (sorry for the extra hassle when reviewing ), if you have any questions send me a message