Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to customize internal HttpClient #254

Merged
merged 4 commits into from
Jan 27, 2023
Merged

Conversation

Arcalise08
Copy link
Contributor

In a situation personally in which I need to directly modify the HttpClient being used in this library. So I added the ability to pass in an HttpClient to the UI options, which is used for the lifetime of the application.

@update-docs
Copy link

update-docs bot commented Jan 26, 2023

Thanks for opening this pull request! If you have implemented new functions, write about them in the readme file.

@Burgyn
Copy link
Owner

Burgyn commented Jan 27, 2023

Hey,

thanks for the PR. The idea is good for me, but I don't like the implementation. I don't want to allow the HttpClient to be entered directly (not good practice). I'd rather just add the ClientName and let the factory create the correct client based on that.

@Arcalise08
Copy link
Contributor Author

I have made the requested changes. I accidently pushed a version change with this which we can rollback if you like. I also noticed that this package doesnt include <GenerateDocumentationFile>true</GenerateDocumentationFile> . I wasnt sure if that was something you had set locally as i cant get comments to show up once packed without it. But other then that I hope this meets your expectations.

@Arcalise08
Copy link
Contributor Author

Sorry about the extra commits. I really shouldnt push changes before my morning coffee

@Burgyn Burgyn merged commit 7708f4f into Burgyn:master Jan 27, 2023
@Burgyn
Copy link
Owner

Burgyn commented Jan 27, 2023

Thanks a lot.

Your changes will be release soon as version 6.1.0 .

@Burgyn
Copy link
Owner

Burgyn commented Jan 27, 2023

Sorry, 6.2.0 of course.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants