Change object IWebHostEnvironment for new IHostEnvironment of net core #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Revert default value of serverOverride * Added .RemoveSlashFromEnd(); in serverOverride
# Conflicts: # README.md # demo/ApiGateway/Startup.cs # src/MMLib.SwaggerForOcelot/DependencyInjection/ServiceCollectionExtensions.cs # src/MMLib.SwaggerForOcelot/Middleware/SwaggerForOcelotMiddleware.cs # src/MMLib.SwaggerForOcelot/ReRouteOptionsExtensions.cs # src/MMLib.SwaggerForOcelot/ServiceDiscovery/SwaggerServiceDiscoveryProvider.cs # src/MMLib.SwaggerForOcelot/Transformation/ISwaggerJsonTransformer.cs # src/MMLib.SwaggerForOcelot/Transformation/SwaggerJsonTransformer.cs # tests/MMLib.SwaggerForOcelot.Tests/ServiceDiscovery/SwaggerServiceDiscoveryProviderShould.cs # tests/MMLib.SwaggerForOcelot.Tests/SwaggerForOcelotMiddlewareShould.cs
# Conflicts: # demo/ApiGateway/Program.cs # src/MMLib.SwaggerForOcelot/DependencyInjection/ConfigurationBuilderExtensions.cs
|
Okay, fine, you're gonna republish the nuget now?, for waiting for me to update my code where I use this nuget |
|
Yes, I republish new version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @Burgyn,
I have detected something interesting in the code of the AddOcelotWithSwaggerSupport extension, and it is that you are using the IWebHostEnvironment object, this object changed in the .NET Core 3.1 version for IHostEnvironment, although you can still use the old object it would be quite interesting to use the new object for future versions of .NET Core