Feature/fp #3
Open
Feature/fp #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Andrew8xx8
suggested changes
Apr 16, 2020
| def rating(_array) | ||
| 0 | ||
| def rating(array) | ||
| hash = { country: 'country', rating: 'rating_kinopoisk' } |
There was a problem hiding this comment.
Зачем выносить названия ключей хеша в другой хеш? Это усложнят читаемость и восприятие сейчас
| hash = { country: 'country', rating: 'rating_kinopoisk' } | ||
| count = 0 | ||
| result = array.select do |film| | ||
| next unless film[hash[:rating]].to_f.positive? |
There was a problem hiding this comment.
Не инвертируй условия, это усложняет восприятие. В руби как правило есть метод-антоним, используй их
Например, negative? — антоним positive?
next if film[hash[:rating]].to_f.negative?
Намного проще, потому что не надо в голове выполнять лишнее НЕ чтобы разобраться что делает код
| result = array.select do |film| | ||
| next unless film[hash[:rating]].to_f.positive? | ||
| next if film[hash[:country]].nil? | ||
| next unless film[hash[:country]].split(',').length >= 2 |
There was a problem hiding this comment.
Тоже самое тут. Проще понимать условие, если меньше двух, чем если не больше или равно двум
| hash = { name: 'name', rating: 'rating_kinopoisk' } | ||
| count = 0 | ||
| films.map do |film| | ||
| next unless film[hash[:rating]].to_f >= threshold |
There was a problem hiding this comment.
Тоже самое тут, не используй unless
| def chars_count(_films, _threshold) | ||
| 0 | ||
| def chars_count(films, threshold) | ||
| hash = { name: 'name', rating: 'rating_kinopoisk' } |
There was a problem hiding this comment.
Тоже самое тут, лишний код, который не добавляет понятности
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.