Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mismatch BlockHash between block header and transaction logs #472

Merged

Conversation

c98tristan
Copy link
Contributor

@c98tristan c98tristan commented Nov 5, 2024

This pull request fixes a mismatch between the block hash in the block header and the transaction logs.

  • For blocks stored in the database before this PR, the stored blockHash may be mismatched, but we can send back to users the correct blockHash.

  • For newly created blocks, the blockHash is set to correct blockHash before storing to the database.

@c98tristan c98tristan marked this pull request as ready for review November 5, 2024 07:39
@c98tristan c98tristan changed the title fix: fix mismatch blockHash between block header and transactions logs fix: fix mismatch blockHash between block header and transaction logs Nov 5, 2024
@tungng98 tungng98 changed the base branch from master to pre-release November 6, 2024 06:18
@tungng98 tungng98 changed the title fix: fix mismatch blockHash between block header and transaction logs Fix mismatch blockHash between block header and transaction logs Nov 6, 2024
@tungng98 tungng98 changed the title Fix mismatch blockHash between block header and transaction logs Fix mismatch blockhash between block header and transaction logs Nov 6, 2024
@tungng98 tungng98 changed the title Fix mismatch blockhash between block header and transaction logs Fix mismatch BlockHash between block header and transaction logs Nov 6, 2024
@tungng98 tungng98 merged commit ac3495e into BuildOnViction:pre-release Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants