-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated metadata #26
base: main
Are you sure you want to change the base?
Updated metadata #26
Conversation
@FrankiePower is attempting to deploy a commit to the BuidlGuidl Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job of implementing the issue, thanks!
I just found a little thing. See below.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
After my second to last commit, as i tested , i discovered that the logic was placed in the SwitchTheme, and so the favicon wasn't changing as expected so i had to move the logic to the ThemeProvider. In the newest changes made, i set up a MutationObserver to listen for changes to the class attribute of the element. If the class attribute changes (indicating a possible switch between dark and light modes), it checks whether the "dark" class is present and updates the favicon accordingly. When the component is unmounted, the observer is disconnected to prevent memory leaks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your changes!
For me your implementation in getMetadata.ts
is already enough and the other code changes are not needed. So not sure why it isn't working on your computer, weird.
@frankie, pls look at the other comments above as well (when you find time). We shouldn't have changes to |
@FrankiePower now there are changes to the main page in the this PR. Pls hold it clean and just have code in here that is related to the metadata. |
d300dc1
to
dd9a89f
Compare
@phipsae i've resolved the commit issues. This PR is ready to be merged. |
@FrankiePower can you please elaborate on that why the changes in getMetadata are not enough? For me it works totally fine. So I don't need to do any changes to ThemeProvider.tsx and SwitchTheme.tsx. Thank you! |
@phipsae i am done with this issue. it is ready to be merged, if there are no further improvements to be made. |
Update Metadata for Better Social Media Previews
Overview
Updated the metadata for the website to provide a custom title, description, and an eye-catching thumbnail. The updated title now appears in the browser tab.
Features
Customized title and description for better branding
![OgraphPreview](https://private-user-images.githubusercontent.com/161265602/402264103-b19b4a94-f729-46d2-83bb-1d343b51a3e8.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg5Njk2ODgsIm5iZiI6MTczODk2OTM4OCwicGF0aCI6Ii8xNjEyNjU2MDIvNDAyMjY0MTAzLWIxOWI0YTk0LWY3MjktNDZkMi04M2JiLTFkMzQzYjUxYTNlOC5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjA3JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIwN1QyMzAzMDhaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1jZGM5OTA5N2NiNzJlZGRmOWVhNTE3NTMxYmJlZjdkMjdmZDQ3NmY3YWZjODY4NmZlMDA1ZjRhOTE3MWY4NGFiJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.Aai4keRPPgcg3jlefVptRM4RvO76V_6w_KRQlkLuDCg)
Eye-catching thumbnail image for social media previews. I used the design provided by @NikolaiL and also modified the background.
![thumbnailPreview](https://private-user-images.githubusercontent.com/161265602/402264072-b04eef03-bd1c-41ad-9ade-5202280acb9e.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg5Njk2ODgsIm5iZiI6MTczODk2OTM4OCwicGF0aCI6Ii8xNjEyNjU2MDIvNDAyMjY0MDcyLWIwNGVlZjAzLWJkMWMtNDFhZC05YWRlLTUyMDIyODBhY2I5ZS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjA3JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIwN1QyMzAzMDhaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1mMDY2NGJhNTU1YWRjNzNjOGRlY2ZlZWZmYjAxYTk1M2QwNjhhZTU1YzdiODk1NmU0M2Y2ZDY4NmNkZmZmMzJlJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.AI3e9fDdsb-LIiMT4bDUwMuPq3m_7q5eR6ylc-Wb7SQ)
Edited the Logo to white to upload for the browser tab
![browsertab](https://private-user-images.githubusercontent.com/161265602/402264281-207c2209-19b5-44f7-ad6a-84d49718ca94.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg5Njk2ODgsIm5iZiI6MTczODk2OTM4OCwicGF0aCI6Ii8xNjEyNjU2MDIvNDAyMjY0MjgxLTIwN2MyMjA5LTE5YjUtNDRmNy1hZDZhLTg0ZDQ5NzE4Y2E5NC5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjA3JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIwN1QyMzAzMDhaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT02MDExYzhhYjRiY2EzNmExMGI4ZjY3M2ZkOGM4ZDM3MDVjZDhmYjYyM2U2OWU2ODY3ZWUyMDhiNjEwMDA3OTc4JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.xmcuGYQHh5ts2E5gT62ph323yDPcpSOh6PNJnRgUSAM)
Technical Implementation
layout.tsx
file to customize the title and description meta tagsthumbnail.jpg
in the Next.js public folder with the new designComponents Updated
layout.tsx
file (for title and description updates)public/thumbnail.jpg
(replaced with new visually appealing image)Additional Information
Subsequent Changes Made
Related Issues
Closes #9
Your ENS/address: 0x24e765Fcd00106D7175837848ec9073f9fEb9d8e