Crashfix for CalendarDay having an undefined props.height #324
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CalendarDay's
calcSizes
calculates a responsivecontainerHeight
by doingMath.round(props.height)
. Ditto for the width.During development,
props.height
would sometimes beundefined
, causing it to doMath.random(undefined)
which yieldedNaN
. This occurred even when an explicitdayComponentHeight
was being passed in. That in turn led to the following error, causing an app crash on Android:containerWidth
was always0
in my logs, so I defaulted it to that and chose to do the same with the height. Have not seen any issues so far.