Fixed numVisibleItems in Scroller component #280
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got the case when
numVisibleItems
is calculated as 6 instead of 7 days and that is ruins paged scrollable. I found that beforeMath.floor()
being applied the raw value is 6.94 which, I believe, is ok since it's calculated upon roundeditemWidth
&marginHorizontal
values. But when you floor thenumVisibleItems
itself it ends up in wrong days & unexpected paging behavior. This PR suggests to replaceMath.floor()
withMath.round()
I suppose it also could be a fix for issue #269