Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More customization options for CalendarHeader #136

Merged
merged 4 commits into from
Apr 11, 2019
Merged

More customization options for CalendarHeader #136

merged 4 commits into from
Apr 11, 2019

Conversation

ruslanchek
Copy link
Contributor

  • Property calendarHeaderPosition added (above | below).
  • Property calendarHeaderContainerStyle added.
  • CalendarHeader now has Text wrapped into View for more customization flexibility.

@ruslanchek
More customization options for CalendarHeader
f271ebc 
- Property calendarHeaderPosition added (above | below).
- Property calendarHeaderContainerStyle added.
- CalendarHeader now has Text wrapped into View for more customization flexibility.
@peacechen
Copy link
Collaborator

Thanks @ruslanchek for the useful new features. Please update the Readme with the new props and I'll merge.

@ruslanchek
Copy link
Contributor Author

Done. Please check the readme.

@peacechen
Copy link
Collaborator

Thanks for updating the Readme. Just curious, is prettier resizing the prop columns, or are you doing that manually? Makes the diff much bigger and difficult to see exactly what changed.

@ruslanchek
Copy link
Contributor Author

OMG that’s prettier sorry. I can fix it :-)

@ruslanchek
Copy link
Contributor Author

Done

@ruslanchek
Update index.d.ts
0454c0b 
Interfaces added
Types added
All unnecessary props now have ? symbol.
@ruslanchek
Copy link
Contributor Author

I've also updated index.d.ts

@peacechen
Copy link
Collaborator

Great work. Thanks again @ruslanchek 👍

@peacechen peacechen merged commit 251703a into BugiDev:master Apr 11, 2019
@ruslanchek
Copy link
Contributor Author

Thank you! Could you also publish new package?

@peacechen
Copy link
Collaborator

1.3.8 was published earlier this morning

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ruslanchek @peacechen