Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

daySelectionAnimation applying border to all days #268

Closed
sperardt opened this issue Feb 4, 2021 · 8 comments
Closed

daySelectionAnimation applying border to all days #268

sperardt opened this issue Feb 4, 2021 · 8 comments

Comments

@sperardt
Copy link

sperardt commented Feb 4, 2021

Hi there,

I am following your examples on the components documentation. When I run the code for having a border around the selected day, all of days of such week get the border.

 <View>
                    <CalendarStrip
                        calendarAnimation={{type: 'sequence', duration: 30}}
                        daySelectionAnimation={{type:'border', duration: 200, borderWidth: 1, borderHighlightColor: 'white'}}
                        style={{height: 100, paddingTop: 20, paddingBottom: 10}}
                        calendarHeaderStyle={{color: 'white'}}
                        calendarColor={'#7743CE'}
                        dateNumberStyle={{color: 'white'}}
                        dateNameStyle={{color: 'white'}}
                        highlightDateNumberStyle={{color: 'yellow'}}
                        highlightDateNameStyle={{color: 'yellow'}}
                        disabledDateNameStyle={{color: 'grey'}}
                        disabledDateNumberStyle={{color: 'grey'}}
                        iconContainer={{flex: 0.1}}
                    />
                </View>

I also have added the prop 'selectedDate' but no difference on the result. Am I missing something?

Screen Shot 2021-02-04 at 12 06 53 PM

Screen Shot 2021-02-04 at 12 07 55 PM

@peacechen
Copy link
Collaborator

That looks like a bug. Would you try reverting to 2.1.5 ?

@sperardt
Copy link
Author

sperardt commented Feb 5, 2021

Hi @peacechen , same result using 2.1.5

@peacechen
Copy link
Collaborator

How about 2.1.4 or earlier? Would help to know which version broke it

@sperardt
Copy link
Author

sperardt commented Feb 8, 2021

Hi @peacechen,

I have been downgraded to other versions and noticed I missed one step when downgrading to 2.1.5. Tested it again and 2.1.5 works as expected. Sorry about that.

Cheers,

peacechen added a commit that referenced this issue Feb 9, 2021
@peacechen
Copy link
Collaborator

A fix has been published 2.1.7. Please confirm whether that version works.

@sperardt
Copy link
Author

sperardt commented Feb 9, 2021

hey @peacechen ,

Apparently, it didn't work and versions 2.1.4, 2.1.5, 2.1.6 are marking all dates with border today.

@peacechen
Copy link
Collaborator

I tested 2.1.7 in the sample project in this repo using the <CalendarStrip> props you provided. You may need to delete node_modules to ensure that you're getting the latest version.

Try the sample project in this repo:
https://github.com/BugiDev/react-native-calendar-strip#development-with-sample-application

@sperardt
Copy link
Author

sperardt commented Feb 9, 2021

looks like I had them cached. Deleted node_modules, cleaned the cache and installed all dependencies again.

2.1.7 is working fine.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants