Validate screen relationship datasource settings #15439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
adrinr
force-pushed
the
BUDI-8986/validate-screen-datasources
branch
from
d4ebf7b to
679ef33
Compare
adrinr
force-pushed
the
BUDI-8986/validate-screen-datasources
branch
from
679ef33 to
92606c6
Compare
adrinr
commented
Jan 27, 2025
| @@ -0,0 +1,74 @@ | |||
| import { makePropSafe } from "@budibase/string-templates" | |||
There was a problem hiding this comment.
This has been moved from packages/builder/src/components/design/settings/controls/DataSourceSelect/DataSourceSelect.svelte
adrinr
changed the title
This was referenced Jan 27, 2025
deanhannigan
approved these changes
Jan 27, 2025
| @@ -24,3 +24,18 @@ export type InsertAtPositionFn = (_: { | |||
| value: string | |||
| cursor?: { anchor: number } | |||
| }) => void | |||
|
|
|||
| export interface UIBinding { | |||
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding validation for relationship fields in datasource selectors. Follow up of #15433
Before
If a component was referencing an element it did not exist on the component chain, it would not complain. It would just return no rows.
Screen.Recording.2025-01-27.at.10.58.32.mov
The same would happen if the relationship were dropped
After
The component using the invalid datasource will complain (either because of a wrong component tree or a dropped relationship)
Screen.Recording.2025-01-27.at.11.05.33.mov
Launchcontrol
Validation relationship fields in datasource settings in components.