Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix selecting 'old row' in row updated trigger. #15432

Merged
merged 1 commit into from
Jan 23, 2025
Merged

Conversation

samwho
Copy link
Collaborator

@samwho samwho commented Jan 23, 2025

Description

If you have an automation with the trigger "row updated" and you open the test data modal and select "old row", it currently does not work.

CleanShot 2025-01-23 at 17 34 19@2x

Was a simple missing null check, this PR fixes it.

Launchcontrol

  • Fixes a missing null check when selecting "old row" to populate test data for an automation run.

Copy link

qa-wolf bot commented Jan 23, 2025

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

@github-actions github-actions bot added firestorm Data/Infra/Revenue Team size/xs labels Jan 23, 2025
@samwho samwho requested a review from deanhannigan January 23, 2025 17:38
@samwho samwho enabled auto-merge January 23, 2025 17:38
Copy link
Contributor

@deanhannigan deanhannigan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔥

@samwho samwho merged commit f3061dc into master Jan 23, 2025
20 checks passed
@samwho samwho deleted the fix-old-row-selector branch January 23, 2025 17:41
@github-actions github-actions bot locked and limited conversation to collaborators Jan 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
firestorm Data/Infra/Revenue Team size/xs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants