forked from pandas-dev/pandas
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Resolving issue request pandas-dev#29738. Updated integer.py to analy…
…ze the types on iteratively going through the collection to cast to the appropriate type. In addition added a basic test case test_native_calls_types to assert that the change works
- Loading branch information
1 parent
b9f26e2
commit c3047f6
Showing
2 changed files
with
11 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c3047f6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code reviewed. You should add more comments to explain the assert in test_native_calls_types(). You should also be more general on the pq.Series dtype.