LFT-1285 - Suppress sync generator in .NET Core build #366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't need the sync implementations but we especially don't want the obligations to implement sync APIs in .NET Core. The spirit of the generator is to make migrating to sync in .NET Framework sustainable, the idea generally is that in .NET Core we won't rely on sync APIs.
j3parker
force-pushed
the
no-sync-.net-core
branch
from
7b48a74 to
eeebd4d
Compare
|
Here's ILSpy showing the net60 build (top) without sync overloads in IPublicKeyDataProvider, and the net472 build (below) with them.
|
j3parker
commented
Aug 1, 2024
| @@ -10,6 +10,10 @@ | |||
| <IncludeSymbols>true</IncludeSymbols> | |||
| </PropertyGroup> | |||
|
|
|||
| <ItemGroup> | |||
| <CompilerVisibleProperty Include="SuppressSyncGenerator" /> | |||
| </ItemGroup> | |||
There was a problem hiding this comment.
Hm, I'll read up on the docs, I was trying to make it so this was not necessary here. I'll probably need another bump of analyzers to get rid of this now.
j3parker
changed the title
omsmith
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't need the sync implementations but we especially don't want the obligations to implement sync APIs in .NET Core. The spirit of the generator is to make migrating to sync in .NET Framework sustainable, the idea generally is that in .NET Core we won't rely on sync APIs.