enforce immutable type params during immutability analysis #874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Decide a type is not immutable if any [Immutable] type parameters to do satisfy that constraint during immutable type analysis. Previously we would assume a different section of the analyzer caught these, as we look at arguments to these type parameters specifically even outside of actual immutable type analysis. Checking during actual immutable type analysis means we don't miss it when it really matters, in case we did otherwise.
omsmith
force-pushed
the
omsmith/enforce-immutable-typeparams
branch
from
f6b83e4 to
5ceb38a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Decide a type is not immutable if any [Immutable] type parameters to do
satisfy that constraint during immutable type analysis.
Previously we would assume a different section of the analyzer caught
these, as we look at arguments to these type parameters specifically
even outside of actual immutable type analysis.
Checking during actual immutable type analysis means we don't miss it
when it really matters, in case we did otherwise.