Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MA-33]: Add aria-live to empty result messages #49

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SaurabhSharma-884
Copy link

@SaurabhSharma-884 SaurabhSharma-884 commented Jan 2, 2025

Summary

  • Added Aria-live to Empty Result message.
  • Removed "application" role from the result region.

Steps to reproduce

MM-61607 :

  • Navigate to the "Search result" modal section.
  • Turn on the screen reader and navigate through the modal.
  • Notice that the "No results for “message”....etc." element is not announced by the screen reader.

MM-61613 :

  • Turn on the screen and navigate to the "Recent Mentions" button then select it.
  • Navigate to the "No mentions yet,....etc." element.
  • Notice that the screen reader does not announce the "No mentions yet,....etc." element.

Expected Behaviour

MM-61607 :
"No results for “message”....etc." element should be announced by the screen reader.

MM-61613 :
"No mentions yet,....etc." element should be announced by the screen reader.

Ticket Link

Fixes:

Screenshots

MM-61607 :

before after
1000044033 1000044032

MM-61613 :

before after
1000044094 1000044093

Release Note

NONE

@SaurabhSharma-884 SaurabhSharma-884 self-assigned this Jan 2, 2025
@SaurabhSharma-884 SaurabhSharma-884 marked this pull request as draft January 2, 2025 13:14
@SaurabhSharma-884 SaurabhSharma-884 marked this pull request as ready for review January 6, 2025 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants