Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MA-44]: Added aria-label to close button #43

Closed
wants to merge 1 commit into from
Closed

[MA-44]: Added aria-label to close button #43

wants to merge 1 commit into from

Conversation

ayush-chauhan233
Copy link
Collaborator

Summary

  • Added aria-label to the modal close button.

Steps to reproduce

  • Locate the "Close" button.
  • Inspect it with Chrome DevTools.
  • In the Accessibility tab, expand the Computed Properties section.
  • Review the value for "Name".

Expected behavior

  • Screen reader must announce the accessible button name.

Ticket Link

Jira https://mattermost.atlassian.net/browse/MM-61658

Screenshots

Before After

Release Note

NONE

@ayush-chauhan233 ayush-chauhan233 self-assigned this Dec 30, 2024
@ayush-chauhan233 ayush-chauhan233 added Approved Dev approved, ready to be reviewed by MM team On External labels Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SaurabhSharma-884 SaurabhSharma-884 SaurabhSharma-884 approved these changes

Assignees

@ayush-chauhan233 ayush-chauhan233

Labels
Approved Dev approved, ready to be reviewed by MM team Merged On External
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ayush-chauhan233 @SaurabhSharma-884