Skip to content

Commit

Permalink
fixed review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
ayusht2810 committed Feb 12, 2024
1 parent 706dd3b commit a56bdab
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 6 deletions.
6 changes: 3 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,9 @@ With the Confluence plugin, you can subscribe to a variety of events in Confluen
- page_updated
- comment_created
- comment_updated
- User can only create the subscriptions for the spaces and pages for which they have permissions to and the same for the notifications too.
- Admins can change permissions for both mattermost and confluence side from the plugin configuration.
![image](https://github.com/mattermost/mattermost-plugin-confluence/assets/90389917/f7e70d82-157b-4dc8-aa0a-868b115f2cb4)
- Users can only create subscriptions for the spaces and pages for which they have permission and same for the notifications as well.
- Admins can change permissions for both Mattermost and Confluence side from the plugin configuration.
![image](https://github.com/Brightscout/mattermost-plugin-confluence-fork/assets/90389917/b94fbf84-f345-4ded-aa8d-21de1b870062)

## Configure notifications

Expand Down
2 changes: 1 addition & 1 deletion plugin.json
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
"key": "RolesAllowedToEditConfluenceSubscriptions",
"display_name": "Mattermost Roles Allowed to Edit Confluence Subscriptions:",
"type": "radio",
"help_text": "Mattermost users who can subscribe channels to confluence space or page.",
"help_text": "Mattermost users who can subscribe channels to Confluence space or page.",
"placeholder": "",
"default": "system_admin",
"options": [
Expand Down
2 changes: 1 addition & 1 deletion server/manifest.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion webapp/src/manifest.js
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ const manifest = JSON.parse(`
"key": "RolesAllowedToEditConfluenceSubscriptions",
"display_name": "Mattermost Roles Allowed to Edit Confluence Subscriptions:",
"type": "radio",
"help_text": "Mattermost users who can subscribe channels to confluence space or page.",
"help_text": "Mattermost users who can subscribe channels to Confluence space or page.",
"placeholder": "",
"default": "system_admin",
"options": [
Expand Down

0 comments on commit a56bdab

Please sign in to comment.