GH-3069 use of Logger with source code generator #3429
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![codescene-delta-analysis[bot]](https://avatars.githubusercontent.com/in/53921?s=60&v=4){kind=small}
| @@ -48,7 +48,7 @@ namespace Paramore.Brighter | |||
| /// Implements both the <a href="http://www.hillside.net/plop/plop2001/accepted_submissions/PLoP2001/bdupireandebfernandez0/PLoP2001_bdupireandebfernandez0_1.pdf">Command Dispatcher</a> | |||
| /// and <a href="http://wiki.hsr.ch/APF/files/CommandProcessor.pdf">Command Processor</a> Design Patterns | |||
| /// </summary> | |||
| public class CommandProcessor : IAmACommandProcessor | |||
| public partial class CommandProcessor : IAmACommandProcessor | |||
There was a problem hiding this comment.
✅ Getting better: Code Duplication
reduced similar code in: DepositPost,DepositPostAsync
|
Do you prefer folks, one big PR to change everything or multi-PRs (one per project)? |
|
@lillo42 Thanks for picking this up. Probably a lot of work. With this kind of change, I tend to suggest that we work as follows:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm starting with one class, so we can validate that I'm going with a good path or if we should change it