Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Fixes issue on resolving on DynamoDb Outbox #3427

Open
wants to merge 2 commits into
base: release/9X
Choose a base branch
from

Conversation

lillo42
Copy link
Contributor

@lillo42 lillo42 commented Dec 16, 2024

The current implementation to avoid duplication makes an infinity loop to find another IAmAnOutbox

Question: Should we allow only one IAmAnOutbox, or should I change the implementation to allow a multi-outbox pattern register but only one DynamoDB?

Copy link

@codescene-delta-analysis codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Health Quality Gates: OK

Change in average Code Health of affected files: +0.00 (10.00 -> 10.00)

View detailed results in CodeScene

@iancooper
Copy link
Member

Question: Should we allow only one IAmAnOutbox
I think we assume only one outbox right now. I don't think we have code that thinks about things like tenancy etc. That would be a bigger piece of work, say V11

Copy link

@codescene-delta-analysis codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Health Quality Gates: OK

Change in average Code Health of affected files: +0.00 (10.00 -> 10.00)

View detailed results in CodeScene

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants