Implement a CombinedProducerRegistryFactory for using multiple message transports [v10]
#3271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhickie
requested review from
iancooper,
holytshirt,
DevJonny and
preardon
as code owners
iancooper
approved these changes
Aug 24, 2024
# Conflicts: # src/Paramore.Brighter.MessagingGateway.AzureServiceBus/AzureServiceBusMessageProducerFactory.cs
iancooper
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #3257 by introducing the concept of a message producer factory for each supported message transport, implementing the new
IAmAMessageProducerFactoryinterface. It also introduces theCombinedProducerRegistryFactory, which takes any number ofIAmAMessageProducerFactoryimplementations to its constructor, and produces aProducerRegistrycontaining all of the producers created by those factories.This makes it possible to publish to multiple message transports from a single Brighter instance, without having to construct and then combine separate producer registries, each of which could fall out of scope and result in exceptions.