support all types supported by rabbit in message headers instead of just strings #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just pushed another change we discussed to my master, because I didn't realize that it will (obviously!) be added to this PR. I should probably have created another branch for this change in isolation, so if you want I can do that. |
|
That's cool, I'll just accept them as rollup fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when a message header contains anything other than a byte[], the message consumer will blow up because the message creator tries to convert all header values into an utf-8 string.
The rabbit mq client supports more types than strings, (like int, long, double, bool and null), so this change will only convert to string if the value is byte[], otherwise just use the value.