Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to ensure check is done for Error.Code.NoError if Error is not null #1778

Merged

Conversation

pieperu
Copy link
Contributor

@pieperu pieperu commented Oct 19, 2021

Fix for #1763

Upon discussion with @iancooper this fix won't come with any code tests as it's quite difficult to test. The only consequence of this bug, is an unnecessary call to create a topic, and the handling of a CreateTopicException - which is to just log a message.

## The output before the fix
image

The output after the fix

image

You can see from the output that after the fix, there are no longer the following message in the output:
Topic xxx is in error with code : NoError and reason : Success
and
Topic xxx already exists

@CLAassistant
Copy link

CLAassistant commented Oct 19, 2021

CLA assistant check
All committers have signed the CLA.

@iancooper
Copy link
Member

@pieperu Shout if you want any advice

@pieperu pieperu force-pushed the fix_existing_topic_check_logic branch from bbbf80a to 8f7b568 Compare October 23, 2021 16:27
@pieperu pieperu marked this pull request as ready for review October 23, 2021 19:03
Copy link
Member

@iancooper iancooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As agreed, our transport and backing store tests are mainly automated regression tests, and TDD mostly happens in the core. Satisfied that this is the right thing to do here

@iancooper iancooper merged commit 6bfaf2b into BrighterCommand:master Oct 23, 2021
@iancooper
Copy link
Member

Thanks for this @pieperu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants