Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Issue #1699 | CommandProcessor.Call(..) works again #1726

Merged
merged 2 commits into from
Sep 22, 2021
Merged

Conversation

DevJonny
Copy link
Contributor

CommandProcessor.Call(..) wasn't working because the individual gateways didn't support the generic Subscription only specific for that gateway. The following changes have been made:

  • ServiceCollectionExtensions.UseExternalBus(..) now takes in an optional IEnumerable<Subscription> for each reply queue type
  • On invocation of .Call(..) the appropriate Subscription is grabbed, and the RoutingKey and ChannelName are set to a new GUID
  • Fixes ServiceCollectionsExtensions to supply an Outbox when using RPC
  • Updates the RMQRequestReply sample to use the new changes

@CLAassistant
Copy link

CLAassistant commented Sep 22, 2021

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@iancooper
Copy link
Member

Thanks. This is a great fix.

@iancooper iancooper merged commit b51baa9 into master Sep 22, 2021
@iancooper iancooper deleted the issue#1699 branch October 11, 2021 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants