Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to V7 of RabbitMQ Client #3386

Open
iancooper opened this issue Nov 10, 2024 · 2 comments
Open

Upgrade to V7 of RabbitMQ Client #3386

iancooper opened this issue Nov 10, 2024 · 2 comments
Labels
2 - In Progress Bug dependencies Pull requests that update a dependency file .NET Pull requests that update .net code v9 Required for v9 release v10 Allocal to a v10 release

Comments

@iancooper
Copy link
Member

Is your feature request related to a problem? Please describe.
RabbitMQ has released version 7, which has breaking changes. This means it is not a simple dependency upgrade, but a code fix. For this reason, raising a ticket to track it.

Describe the solution you'd like
There is a migration guide at: https://github.com/rabbitmq/rabbitmq-dotnet-client/blob/main/v7-MIGRATION.md

Describe alternatives you've considered
We could chose to remain on 6.X.X for longer, but as we encapsulate the RMQ dependency for our users, there is no real benefit to doing so

Additional context
Possible difficulties include async code and our own event consumer

@iancooper iancooper added 0 - Backlog Bug dependencies Pull requests that update a dependency file v10 Allocal to a v10 release v9 Required for v9 release .NET Pull requests that update .net code labels Nov 10, 2024
lillo42 added a commit to lillo42/Brighter that referenced this issue Dec 4, 2024
lillo42 added a commit to lillo42/Brighter that referenced this issue Dec 4, 2024
@iancooper
Copy link
Member Author

iancooper commented Dec 11, 2024

@lillo42 I suggest that we make this change for V10 only, following completion of the work in #3418. I'll get the work finished soon, then we can merge and get this in for V10

@iancooper
Copy link
Member Author

This means overall our strategy is: V9 => V6 RMQ, V10 => V7 RMQ. Once we see the performance implications for RMQ on V10 (mainly significant around expectations for the Reactor as opposed to Proactor pipeline).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2 - In Progress Bug dependencies Pull requests that update a dependency file .NET Pull requests that update .net code v9 Required for v9 release v10 Allocal to a v10 release
Projects
None yet
Development

No branches or pull requests

1 participant